Added health_db_adapter endpoint #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanZotin
force-pushed
the
main
branch
4 times, most recently
from
e528204 to
97fe70a
Compare
SyrexMinus
reviewed
Jun 18, 2024
core/db_adapter/aioredis_adapter.py
Outdated
| return self.db_adapter._redis.ping() | ||
| except Exception as _: | ||
| log("AIORedisAdapter is not alive", level="INFO") | ||
| return |
There was a problem hiding this comment.
Suggested change
| return |
Python по умолчанию так делает окончанию функции
SyrexMinus
reviewed
Jun 18, 2024
|
|
||
| async def is_alive(self): | ||
| try: | ||
| await self.db_adapter._sentinel.sentinels() |
There was a problem hiding this comment.
IvanZotin
force-pushed
the
main
branch
3 times, most recently
from
bdb3a25 to
bd21052
Compare
SyrexMinus
reviewed
Jun 18, 2024
| status, reason, answer = 200, "OK", "ok" | ||
| is_alive = await self.db_adapter.is_alive() | ||
| if not is_alive: | ||
| status, reason, answer = 500, "ERROR", "db adapter connection error" |
There was a problem hiding this comment.
Давай прокинем в reason комментарий из Exception'а из is_alive?
SyrexMinus
reviewed
Jun 18, 2024
core/db_adapter/aioredis_adapter.py
Outdated
| @@ -70,3 +70,9 @@ async def _path_exists(self, path): | |||
|
|
|||
| async def _on_prepare(self): | |||
| pass | |||
|
|
|||
| async def is_alive(self): | |||
There was a problem hiding this comment.
Suggested change
| async def is_alive(self): | |
| async def is_alive(self) -> bool | None: |
Давай аннотациями приправим
IvanZotin
force-pushed
the
main
branch
2 times, most recently
from
3bf7d54 to
e69fa04
Compare
SyrexMinus
approved these changes
Jun 18, 2024
SyrexMinus
reviewed
Jun 18, 2024
core/db_adapter/ignite_adapter.py
Outdated
| try: | ||
| await self.connect() | ||
| return True | ||
| except Exception as _: |
There was a problem hiding this comment.
Suggested change
| except Exception as _: | |
| except Exception: |
IvanZotin
force-pushed
the
main
branch
2 times, most recently
from
402e40f to
cc24cc5
Compare
SyrexMinus
reviewed
Jun 18, 2024
core/db_adapter/aioredis_adapter.py
Outdated
| @@ -70,3 +70,9 @@ async def _path_exists(self, path): | |||
|
|
|||
| async def _on_prepare(self): | |||
| pass | |||
|
|
|||
| async def is_alive(self) -> bool | None: | |||
There was a problem hiding this comment.
Suggested change
| async def is_alive(self) -> bool | None: | |
| async def is_alive(self) -> Optional[bool]: |
+ импорт
Это для поддержки Python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/health_db_adapter - This endpoint returns 200 if the service is available and it can connect to db_adapter (e.g., Ignite) and 500 if the service is unavailable or cannot connect to db_adapter