Fix ILlmApplication.IValidationHook type
#204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type safety issue in the IValidationHook type definition by correcting the parameter order in the validation function signature. The change ensures that validation hooks properly accept unknown input and return validation results typed to match the expected argument type.
- Reversed the type parameters in
IValidationHookto improve type safety - Changed validation functions to accept
unknowninput instead of typed input - Updated return type to be
IValidation<Argument>instead ofIValidation<unknown>
samchon
changed the title
ILlmApplication.ValidationHook typeILlmApplication.IValidationHook type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
IValidationHooktype inILlmApplication.tsto improve type safety for validation hooks. The main change reverses the type parameter in the validation function to ensure the input is correctly typed asunknownand the validation result matches the expected argument type.Type safety improvement:
IValidationHooktype so that validation functions now accept an input of typeunknownand return anIValidationof the expected argument type, rather than the reverse. This ensures more robust and predictable type checking for validation hooks.