Merged
Conversation
Collaborator
|
@jphenow nice to see you again. If you are on v1, I will try my be more active from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #224: the gem previously auto-rendered
head :forbiddenwhen SAML request validation failed, but now exposes errors via request.errors and requires applications to handle the rendering themselves.From the PR comments:
Application must now check request.errors and handle accordingly
This breaks existing applications that relied on automatic error responses.
@Zogoo: "This was not UX friendly option that rendered a black screen from the gem. We should leave this decision to the application side."
Other significant changes:
Various signature validation improvements
Per semantic versioning, API changes that break existing implementations require a major version bump.