Skip to content

SamlIDP v1#239

Merged
jphenow merged 1 commit intomasterfrom
jphenow/v1
Oct 9, 2025
Merged

SamlIDP v1#239
jphenow merged 1 commit intomasterfrom
jphenow/v1

Conversation

@jphenow
Copy link
Collaborator

@jphenow jphenow commented Oct 9, 2025

In PR #224: the gem previously auto-rendered head :forbidden when SAML request validation failed, but now exposes errors via request.errors and requires applications to handle the rendering themselves.

From the PR comments:

# Old behavior (automatic):
head :forbidden if defined?(::Rails)

# New behavior (manual):
return true if valid_saml_request?

Application must now check request.errors and handle accordingly

This breaks existing applications that relied on automatic error responses.

@Zogoo: "This was not UX friendly option that rendered a black screen from the gem. We should leave this decision to the application side."

Other significant changes:

Per semantic versioning, API changes that break existing implementations require a major version bump.

@jphenow jphenow merged commit e7af4e2 into master Oct 9, 2025
30 checks passed
@jphenow jphenow deleted the jphenow/v1 branch October 9, 2025 18:11
@jphenow jphenow restored the jphenow/v1 branch October 9, 2025 18:11
@Zogoo
Copy link
Collaborator

Zogoo commented Oct 13, 2025

@jphenow nice to see you again. If you are on v1, I will try my be more active from now.
Regarding the issue, I can bring back the previous head :forbidden with optional config if you think that's better than bumping the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants