ci.yml workflow: bump upload-artifact to v4 #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
sorry for the slow response, you need to change |
Contributor
this is now done in gh-116 |
15r10nk
pushed a commit
that referenced
this pull request
Sep 17, 2025
``` tests/integration_python/test_main_cli.py:1481: error: No overload variant of "IsList" matches argument type "EllipsisType" [call-overload] tests/integration_python/test_main_cli.py:1481: note: Possible overload variants: tests/integration_python/test_main_cli.py:1481: note: def IsList(self, *items: Any, check_order: bool = ..., length: int | tuple[int, int | Any] | None = ...) -> IsList tests/integration_python/test_main_cli.py:1481: note: def IsList(self, positions: dict[int, Any], length: int | tuple[int, int | Any] | None = ...) -> IsList ``` An ellipsis is a valid argument, as shown in the docs: https://dirty-equals.helpmanual.io/latest/types/sequence/?h=isl#dirty_equals.IsList. closes gh-110 --------- Co-authored-by: Francesco Bruzzesi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 of actions/upload-artifact or actions/download-artifact are going away end of Januari: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
I was grepping through my repo's and noticed my local dirty-equals clone was still on v3:
dirty-equals/.github/workflows/ci.yml
Line 94 in 065162a