Update pvl_singlediode.m #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added iteration limit on while loop. This can be infinite if inputs are unreasonable (see comments on pvl_perez). It's good form to let user know source of error.
cwhanse
approved these changes
Feb 7, 2019
pvl_singlediode.m
Outdated
| while max(abs(B-A))>1e-6 % set precision of estimate of Imp to 1e-6 (A) | ||
| gA=g(A,Iph,Io,a,Rs,Rsh); % value of dP/dV at left endpoint | ||
| u=(gA.*err)<0; | ||
| B(u)=p(u); | ||
| A(~u)=p(~u); | ||
| p=(A+B)/2; | ||
| err = g(p,Iph,Io,a,Rs,Rsh); | ||
|
|
||
| iterCount = iterCount + 1; | ||
| if iterCount > 1000 |
There was a problem hiding this comment.
I don't object to adding iterCount as insurance against some kind of erroneous behavior in the helper function g(), but perhaps reduce the limit to 50. In this bisection, convergence is achieved at an interval of width < 1e-6, from a starting interval between 0 and Iph. A reasonably large value of Iph is 10. In this case convergence is reached after ~20 iterations, assuming the code functions as intended.
50 iterations seems fine. My current data ran fine with this limit. Thanks,
|
Please add a line to the |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added iteration limit on while loop. This can be infinite if inputs are unreasonable (see comments on pvl_perez). It's good form to let user know source of error.