Skip to content

Conversation

@gregjacobus
Copy link
Collaborator

@gregjacobus gregjacobus commented Dec 17, 2025

Confirm before exiting docker container

Description

In the current version of the docker container, it's very easy to accidentally lose all experiment progress by closing the final tmux pane. This PR changes it so that when the tmux session ends, the user is prompted if they really want to exit the docker container. If they don't choose "yes", it will create a new tmux session.

Related Issue

N/A

Type of Change

Please select the type of change your pull request introduces:

  • Bugfix
  • New feature
  • Documentation update
  • Other (please describe):

Checklist

  • This PR conforms to the process detailed in the Contributing Guide.
  • I have included no proprietary/sensitive information in my code.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested my code.

…'t accidentally kill the firewheel environment
@github-actions github-actions bot added the feature New feature or request label Dec 17, 2025
@gregjacobus gregjacobus requested a review from sdelliot December 17, 2025 03:19
while true;
do
tmux
read -p "Exit? (yes/no); " response
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something a bit more clear? "Exit and shutdown container? (yes/no); " or "Exit and kill container (yes/no); " or "Are you sure you want to end your experiment because the container is dying and you can't get it back (yes/no)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants