Skip to content

Y25-217: Remove the y24-220-enable-tag-set API feature flag in SS, allowing the removal of tag group functionality on the CustomTaggedPlate page. #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

seenanair
Copy link
Contributor

@seenanair seenanair commented Mar 24, 2025

Closes sanger/sequencescape#4766

Changes proposed in this pull request

  • Refactor Taglayout and TagLayoutManipulations components
    • Remove tag group functionality and replace with tag set handling

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (bbce6fd) to head (6e92fda).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
- Coverage    81.76%   81.70%   -0.07%     
===========================================
  Files          494      494              
  Lines        19239    19221      -18     
  Branches       363      362       -1     
===========================================
- Hits         15731    15704      -27     
- Misses        3506     3515       +9     
  Partials         2        2              
Flag Coverage Δ
javascript 75.52% <ø> (-0.12%) ⬇️
pull_request 81.70% <ø> (-0.07%) ⬇️
push 81.70% <ø> (-0.07%) ⬇️
ruby 91.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seenanair seenanair marked this pull request as ready for review July 1, 2025 09:53
@seenanair seenanair requested a review from yoldas July 1, 2025 10:18
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@seenanair seenanair merged commit 861a26e into develop Jul 1, 2025
16 checks passed
@seenanair seenanair deleted the y25-217-remove_y24_220_enable_tag_set_api_feature_flag branch July 1, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y25-217 - Removal of y24_220_enable_tag_set_api feature flag
2 participants