-
Notifications
You must be signed in to change notification settings - Fork 8
DPL-903 Bioscan - Add automatic library prep submissions #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…config to handle branched pipelines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2377 +/- ##
===========================================
+ Coverage 81.72% 81.76% +0.04%
===========================================
Files 494 496 +2
Lines 19248 19313 +65
Branches 362 362
===========================================
+ Hits 15731 15792 +61
- Misses 3515 3519 +4
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces automatic library prep submissions for Bioscan by updating configuration settings, adding a new submission presenter, and implementing relevant state machine behavior. Key changes include test specs for the new presenter, configuration updates in YAML and robots files, and adjustments to the workline identifier methods to support arrays.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
spec/models/presenters/submission_when_passed_plate_presenter_spec.rb | Adds tests for the new SubmissionWhenPassedPlatePresenter with various submission contexts |
spec/models/labels/plate_384_single_label_spec.rb | Adds tests for first_of_configured_purpose including array support for alternative workline identifiers |
config/robots.rb | Updates robot configuration comment and purpose values to include both Lysate and Lysate Input |
config/purposes/bioscan.yml | Updates plate configuration for submission options and alternative workline identifiers |
config/pipelines/high_throughput_bioscan.yml | Adjusts pipeline relationships to include Lysate Input |
app/sequencescape/sequencescape/api/v2/shared/has_workline_identifier.rb | Modifies workline_reference to support array config values for alternative workline identifiers |
app/models/presenters/submission_when_passed_plate_presenter.rb | Introduces a new presenter for handling submissions when a plate passes |
app/models/labels/plate_384_single_label.rb | Updates the method to resolve the first matching ancestor based on alternative workline identifiers |
app/models/concerns/presenters/statemachine/submission_when_passed.rb | Implements a state machine for submission behavior on plates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments, but looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't fully remember the randomised controls and lysate negative discussion to check a few more points but overall this PR looks very good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but basically seems good I think!
else | ||
# Original behavior for a single purpose name | ||
ancestors.where(purpose_name: alternative_workline_identifier_purpose).last | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if this file actually needed any code changes -
ancestors.where(purpose_name: alternative_workline_identifier_purpose).last
'where' works with arrays as well as single items, doesn't it?
I expect something blew up though, since you're changing it!
Co-authored-by: KatyTaylor <[email protected]>
Closes #1381
Changes proposed in this pull request
Modifies Bioscan configuration to allow automatic library prep submissions.
Adds a new submission presenter and statemachine.