Adding allow route overwrite option in blueprint by ChihweiLHBird · Pull Request #2716 · sanic-org/sanic

ChihweiLHBird · 2023-03-19T06:33:51Z

codecov · 2023-03-19T06:39:01Z

Codecov Report

Patch coverage: 100.000% and project coverage change: -0.044 ⚠️

Comparison is base (af67801) 88.938% compared to head (17471f1) 88.895%.

❗ Current head 17471f1 differs from pull request most recent head abe0657. Consider uploading reports for the commit abe0657 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #2716       +/-   ##
=============================================
- Coverage   88.938%   88.895%   -0.044%     
=============================================
  Files           92        92               
  Lines         6952      6961        +9     
  Branches      1185      1188        +3     
=============================================
+ Hits          6183      6188        +5     
- Misses         527       529        +2     
- Partials       242       244        +2

Impacted Files	Coverage Δ
sanic/router.py	`96.000% <ø> (ø)`
sanic/app.py	`90.119% <100.000%> (+0.016%)`	⬆️
sanic/asgi.py	`91.729% <100.000%> (+0.062%)`	⬆️
sanic/blueprints.py	`91.549% <100.000%> (+0.161%)`	⬆️
sanic/mixins/routes.py	`96.747% <100.000%> (+0.081%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ahopkins

Don't forget a test 😎

ahopkins · 2023-03-20T14:00:39Z

@ChihweiLHBird Don't bother trying to keep it up to date and merging in latest (unless part of a local commit). It will likely change 10 more times before this is ready. I will make sure it is up to date when the time comes.

ChihweiLHBird · 2023-03-20T14:12:16Z

@ahopkins Thanks! I added one test case for overwriting route after bp copy. It probably needs another test case for a non-copied blueprint to allow overwriting a route handler. Do you plan to include this PR in this release?

ahopkins · 2023-03-20T14:21:16Z

Do you plan to include this PR in this release?

If its finished, yes.

ChihweiLHBird · 2023-03-20T14:25:41Z

GitHub seems having a delay to sync branch with PR...

By the way, I try initializing a bp instance with overwriting route option set to True, and it seems it is not functioning well. I would prefer to postpone this to the next release instead of rushing it out.

ahopkins · 2023-03-20T14:28:28Z

Works for me.

ChihweiLHBird · 2023-03-20T14:29:01Z

@ahopkins Thanks!

ChihweiLHBird · 2023-06-27T03:01:31Z

We can consider to proceed with this PR if that's a better way to implement it.

* Adding allow route overwrite option * Add test case for route overwriting after bp copy * Fix test * Fix * Add test case `test_bp_allow_override` * Remove conflicted future routes when overwriting is allowed * Improved test test_bp_copy_with_route_overwriting * Fix type * Fix type 2 * Add `test_bp_copy_without_route_overwriting` case * make `allow_route_overwrite` flag to be internal * Remove unwanted test case --------- Co-authored-by: Adam Hopkins <adam@amhopkins.com>

Adding allow route overwrite option

50220ec

ahopkins reviewed Mar 19, 2023

View reviewed changes

Merge branch 'main' into zhiwei/route-overwrite

e569634

Add test case for route overwriting after bp copy

19d0023

Fix test

158cf16

ChihweiLHBird marked this pull request as ready for review March 20, 2023 14:16

ChihweiLHBird requested a review from a team as a code owner March 20, 2023 14:16

ChihweiLHBird force-pushed the zhiwei/route-overwrite branch from 260c3a1 to 158cf16 Compare March 20, 2023 14:19

ChihweiLHBird requested a review from a team as a code owner March 20, 2023 14:19

ahopkins reviewed Mar 20, 2023

View reviewed changes

Comment thread 1.py Outdated

ChihweiLHBird force-pushed the zhiwei/route-overwrite branch from 76fce02 to 158cf16 Compare March 20, 2023 14:21

ahopkins reviewed Mar 20, 2023

View reviewed changes

Comment thread tests/test_blueprint_copy.py Outdated

ChihweiLHBird marked this pull request as draft March 20, 2023 14:25

ChihweiLHBird added 5 commits March 29, 2023 00:12

Merge branch 'main' into zhiwei/route-overwrite

4536fd0

Fix

2c6bb64

Merge branch 'main' into zhiwei/route-overwrite

1cee6da

Add test case test_bp_allow_override

20dda24

Remove conflicted future routes when overwriting is allowed

f6738ee

ChihweiLHBird marked this pull request as ready for review April 25, 2023 06:35

ChihweiLHBird added 3 commits April 25, 2023 02:43

Improved test test_bp_copy_with_route_overwriting

de6e692

Fix type

c7d740c

Fix type 2

c1d03eb

ChihweiLHBird requested a review from ahopkins May 22, 2023 06:41

ahopkins reviewed May 30, 2023

View reviewed changes

Comment thread tests/test_blueprint_copy.py

ahopkins reviewed May 30, 2023

View reviewed changes

Comment thread tests/test_blueprints.py Outdated

Add test_bp_copy_without_route_overwriting case

efa9f93

ChihweiLHBird requested a review from ahopkins June 11, 2023 02:18

Merge branch 'main' into zhiwei/route-overwrite

e6c51e1

ahopkins added 2 commits July 5, 2023 11:28

Merge branch 'main' into zhiwei/route-overwrite

17471f1

Merge branch 'main' into zhiwei/route-overwrite

abe0657

ChihweiLHBird changed the title ~~Adding Allow Route Overwrite Option in Blueprint~~ Adding allow route overwrite option in blueprint Jul 6, 2023

ChihweiLHBird added 3 commits July 7, 2023 02:11

make allow_route_overwrite flag to be internal

e6c65fe

Remove unwanted test case

7a284f3

Merge branch 'main' into zhiwei/route-overwrite

111e4f7

ahopkins approved these changes Jul 7, 2023

View reviewed changes

ahopkins merged commit e374409 into main Jul 7, 2023

ahopkins deleted the zhiwei/route-overwrite branch July 7, 2023 11:56

ahopkins mentioned this pull request Jul 9, 2023

Parameter [overwrite] is supported when adding a route. #2746

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding allow route overwrite option in blueprint#2716

Adding allow route overwrite option in blueprint#2716
ahopkins merged 19 commits into
mainfrom
zhiwei/route-overwrite

ChihweiLHBird commented Mar 19, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Mar 19, 2023 •

edited

Loading

Uh oh!

ahopkins left a comment

Uh oh!

ahopkins commented Mar 20, 2023 •

edited

Loading

Uh oh!

ChihweiLHBird commented Mar 20, 2023

Uh oh!

ahopkins commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

ChihweiLHBird commented Mar 20, 2023 •

edited

Loading

Uh oh!

ahopkins commented Mar 20, 2023

Uh oh!

ChihweiLHBird commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

ChihweiLHBird commented Jun 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ChihweiLHBird commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ahopkins left a comment

Choose a reason for hiding this comment

Uh oh!

ahopkins commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChihweiLHBird commented Mar 20, 2023

Uh oh!

ahopkins commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

ChihweiLHBird commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahopkins commented Mar 20, 2023

Uh oh!

ChihweiLHBird commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

ChihweiLHBird commented Jun 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ChihweiLHBird commented Mar 19, 2023 •

edited

Loading

codecov Bot commented Mar 19, 2023 •

edited

Loading

ahopkins commented Mar 20, 2023 •

edited

Loading

ChihweiLHBird commented Mar 20, 2023 •

edited

Loading