Skip to content

fix #2757 - Improved error messaging on startup time application induced import error#2770

Merged
ahopkins merged 3 commits into
sanic-org:mainfrom
moshe742:main
Jul 5, 2023
Merged

fix #2757 - Improved error messaging on startup time application induced import error#2770
ahopkins merged 3 commits into
sanic-org:mainfrom
moshe742:main

Conversation

@moshe742

@moshe742 moshe742 commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Closes #2757

@moshe742 moshe742 requested a review from a team as a code owner July 5, 2023 09:39
@ahopkins ahopkins changed the title fix #2757 fix #2757 - Improved error messaging on startup time application induced import error Jul 5, 2023
ahopkins
ahopkins previously approved these changes Jul 5, 2023
@codecov

codecov Bot commented Jul 5, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (f2cc83c) 88.944% compared to head (fd14a45) 88.944%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2770   +/-   ##
=========================================
  Coverage   88.944%   88.944%           
=========================================
  Files           92        92           
  Lines         6956      6956           
  Branches      1185      1185           
=========================================
  Hits          6187      6187           
  Misses         527       527           
  Partials       242       242           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit f48506d into sanic-org:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular import in target file accidentally triggers 'No module named ... found'

2 participants