Set multiprocessing start method early#2776
Merged
Merged
Conversation
…nto set-start-method-early
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
=============================================
+ Coverage 88.923% 88.944% +0.020%
=============================================
Files 92 92
Lines 6988 7001 +13
Branches 1192 1194 +2
=============================================
+ Hits 6214 6227 +13
Misses 529 529
Partials 245 245
☔ View full report in Codecov by Sentry. |
prryplatypus
previously approved these changes
Jul 9, 2023
prryplatypus
approved these changes
Jul 9, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the context as early as possible. Since
get_context("spawn")is not the same asset_start_method("spawn")andget_context(), we are adopting the second pattern. This should allow for less "gotchas" when usingmultiprocessingprimitives likemultiprocessing.Queue.