Skip to content

Remove Python3.7 support#2777

Merged
ahopkins merged 5 commits into
mainfrom
remove-3.7
Jul 9, 2023
Merged

Remove Python3.7 support#2777
ahopkins merged 5 commits into
mainfrom
remove-3.7

Conversation

@ahopkins

@ahopkins ahopkins commented Jul 9, 2023

Copy link
Copy Markdown
Member

No description provided.

@ahopkins ahopkins requested review from a team as code owners July 9, 2023 18:27
@prryplatypus

Copy link
Copy Markdown
Member

Should it be removed from setup.py too?

@codecov

codecov Bot commented Jul 9, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.000% and project coverage change: -0.048 ⚠️

Comparison is base (5dd1623) 88.971% compared to head (c3a0528) 88.923%.

❗ Current head c3a0528 differs from pull request most recent head 7bd243c. Consider uploading reports for the commit 7bd243c to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2777       +/-   ##
=============================================
- Coverage   88.971%   88.923%   -0.048%     
=============================================
  Files           92        92               
  Lines         6991      6988        -3     
  Branches      1193      1192        -1     
=============================================
- Hits          6220      6214        -6     
- Misses         527       529        +2     
- Partials       244       245        +1     
Impacted Files Coverage Δ
sanic/models/asgi.py 100.000% <ø> (ø)
sanic/app.py 90.169% <100.000%> (ø)
sanic/server/runners.py 90.000% <100.000%> (+0.714%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins

ahopkins commented Jul 9, 2023

Copy link
Copy Markdown
Member Author

Should it be removed from setup.py too?

image

Am I missing another location in setup.py?

prryplatypus
prryplatypus previously approved these changes Jul 9, 2023
@prryplatypus

Copy link
Copy Markdown
Member

Am I missing another location in setup.py?

Nah, just didn't see it earlier for some reason

@ahopkins ahopkins merged commit 4a2b82e into main Jul 9, 2023
@ahopkins ahopkins deleted the remove-3.7 branch July 9, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants