Skip to content

Fix test_fast when there's only one CPU#2801

Merged
ahopkins merged 3 commits into
sanic-org:mainfrom
tjni:test-one-cpu
Sep 6, 2023
Merged

Fix test_fast when there's only one CPU#2801
ahopkins merged 3 commits into
sanic-org:mainfrom
tjni:test-one-cpu

Conversation

@tjni

@tjni tjni commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

I ran into this when running the tests in a VM that only had one CPU.

@tjni tjni requested a review from a team as a code owner August 17, 2023 04:43

@SaidBySolo SaidBySolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than an if statement, it would be better to write one more test function when there is only one worker.

I checked again and it seems to be ok :)

@codecov

codecov Bot commented Aug 23, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.354% 🎉

Comparison is base (d255d1a) 88.429% compared to head (402aa43) 88.783%.

❗ Current head 402aa43 differs from pull request most recent head 1f6daea. Consider uploading reports for the commit 1f6daea to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2801       +/-   ##
=============================================
+ Coverage   88.429%   88.783%   +0.354%     
=============================================
  Files           92        92               
  Lines         7156      7052      -104     
  Branches      1228      1197       -31     
=============================================
- Hits          6328      6261       -67     
+ Misses         574       542       -32     
+ Partials       254       249        -5     

see 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit eb3d78f into sanic-org:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants