Fix Docker publish#2887
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
=============================================
- Coverage 88.160% 88.026% -0.135%
=============================================
Files 94 94
Lines 7433 7433
Branches 1283 1283
=============================================
- Hits 6553 6543 -10
- Misses 616 623 +7
- Partials 264 267 +3 ☔ View full report in Codecov by Sentry. |
The actions uses data from the release object itself, so workflow dispatch doesn't work anyway
ahopkins
previously approved these changes
Jan 1, 2024
ahopkins
reviewed
Jan 1, 2024
Member
Author
|
Images for v23.12.0 have been uploaded to Docker Hub. And fixed another couple of issues along the way 🙂 |
ahopkins
approved these changes
Jan 1, 2024
ahopkins
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fix Docker publish (#2887) * Fix Docker publish * Remove workflow dispatch The actions uses data from the release object itself, so workflow dispatch doesn't work anyway * More fixes * DOCS: small fix to class name small typo fix for the logger Sanic extension --------- Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
ahopkins
added a commit
that referenced
this pull request
Jan 9, 2024
* Add test for issue #2823 * Do not strip entity-headers. * Remove unused import * Remove remove_entity_headers() * Add workflow_dispatch release * RTD build fix * RTD build fix (another) * RTD build fix (yet another) * Update Crowdin configuration file * Fix Docker publish (#2887) * Fix Docker publish * Remove workflow dispatch The actions uses data from the release object itself, so workflow dispatch doesn't work anyway * More fixes * Remove test for removed functionality. --------- Co-authored-by: L. Kärkkäinen <Tronic@users.noreply.github.com> Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
ahopkins
added a commit
that referenced
this pull request
Jun 30, 2024
* Add workflow_dispatch release * RTD build fix * RTD build fix (another) * RTD build fix (yet another) * Update Crowdin configuration file * Fix Docker publish (#2887) * Fix Docker publish * Remove workflow dispatch The actions uses data from the release object itself, so workflow dispatch doesn't work anyway * More fixes * Backport PRs 2979 2980 * Cleanup tests --------- Co-authored-by: Néstor Pérez <25409753+prryplatypus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.