Skip to content

Ensure proper intent for noisy exceptions#2960

Merged
ahopkins merged 2 commits into
mainfrom
proper-intent-for-noisy-exceptions
Jun 23, 2024
Merged

Ensure proper intent for noisy exceptions#2960
ahopkins merged 2 commits into
mainfrom
proper-intent-for-noisy-exceptions

Conversation

@ahopkins

Copy link
Copy Markdown
Member

There is currently an unintended consequence when running via CLI in that not providing --noisy-exceptions or --no-noisy-exceptions sets NOISY_EXCEPTIONS to False. Since the runtime overrides the app specific config, this leads to unintended consequences where the app should be respected if the runtime does not define a behavior.

@ahopkins ahopkins requested a review from a team as a code owner June 22, 2024 20:44
@ahopkins ahopkins merged commit f04c5ab into main Jun 23, 2024
@ahopkins ahopkins deleted the proper-intent-for-noisy-exceptions branch June 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant