Skip to content

Fix incompatible type annotation of get method in the HTTPMethodView class#3016

Merged
ahopkins merged 3 commits into
mainfrom
zhiwei/http-view-get-typing
Dec 22, 2024
Merged

Fix incompatible type annotation of get method in the HTTPMethodView class#3016
ahopkins merged 3 commits into
mainfrom
zhiwei/http-view-get-typing

Conversation

@ChihweiLHBird

Copy link
Copy Markdown
Member

Resolves #2916

Use getattr to try getting the get handler to avoid the typing annotation incompatibility issue.

@ChihweiLHBird ChihweiLHBird requested a review from a team as a code owner December 18, 2024 08:59
@ChihweiLHBird ChihweiLHBird changed the title Remove incompatible type annotation of get method in the HTTPMethodView class Fix incompatible type annotation of get method in the HTTPMethodView class Dec 18, 2024
Comment thread sanic/views.py Outdated
@ahopkins ahopkins merged commit 0d34d1c into main Dec 22, 2024
@ahopkins ahopkins deleted the zhiwei/http-view-get-typing branch December 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy error type for async get function in HTTPMethodView

2 participants