Fix AttributeError in close_if_idle() when _http is not initialized#3085
Merged
ahopkins merged 2 commits intoNov 30, 2025
Merged
Conversation
Fixes #3081 During server shutdown, the _cleanup() function in runners.py calls close_if_idle() on all connection objects. However, if a connection was created but connection_task() hasn't called _setup_connection() yet, the _http attribute doesn't exist, causing an AttributeError. The HttpProtocolMixin already provides an 'http' property (lines 73-77) that safely handles this case using hasattr(). This commit updates close_if_idle() to use the property instead of direct attribute access. Changes: - Changed self._http to self.http in close_if_idle() method - This leverages the existing property that returns None when _http doesn't exist yet - Maintains exact same behavior for initialized connections - Prevents AttributeError for uninitialized connections during shutdown
ahopkins
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3081
During server shutdown, the _cleanup() function in runners.py calls close_if_idle() on all connection objects. However, if a connection was created but connection_task() hasn't called _setup_connection() yet, the _http attribute doesn't exist, causing an AttributeError.
The HttpProtocolMixin already provides an 'http' property (lines 73-77) that safely handles this case using hasattr(). This commit updates close_if_idle() to use the property instead of direct attribute access.
Changes: