Skip to content

fixing bad term cleanup at exit#3088

Merged
ahopkins merged 7 commits into
sanic-org:mainfrom
tdaron:main
Dec 28, 2025
Merged

fixing bad term cleanup at exit#3088
ahopkins merged 7 commits into
sanic-org:mainfrom
tdaron:main

Conversation

@tdaron

@tdaron tdaron commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

This fixes #2900 by simply saving term info and registering an on-exit handler to put correct term info back at the exit

@tdaron tdaron requested a review from a team as a code owner November 18, 2025 12:39
@tdaron

tdaron commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

CI is failing cause of some RNG, i think this is not related to this PR. Is there anything I should do about it ?

@ahopkins

Copy link
Copy Markdown
Member

Let's not add a dependency here. Let's find a solution without it.

@tdaron

tdaron commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

Hi ! Thanks for your answer ! I think both termios and atexit are part of python's std library, so it should not add any dependency. But as termios is POSIX only, it requires the try except for the import. So my patch will not affect at all non-POSIX systems but AFAIK those are not concerned with the issue.

@ahopkins ahopkins requested a review from a team as a code owner December 28, 2025 10:20
@codecov

codecov Bot commented Dec 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.683%. Comparing base (b51fa73) to head (875b7fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3088   +/-   ##
=========================================
  Coverage   87.683%   87.683%           
=========================================
  Files          104       104           
  Lines         7778      7778           
  Branches      1236      1236           
=========================================
  Hits          6820      6820           
  Misses         662       662           
  Partials       296       296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahopkins ahopkins merged commit 85cb988 into sanic-org:main Dec 28, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: Terminal becomes no-echo if not entering REPL mode or exiting without Ctrl+D

2 participants