fixing bad term cleanup at exit#3088
Merged
Merged
Conversation
Contributor
Author
|
CI is failing cause of some RNG, i think this is not related to this PR. Is there anything I should do about it ? |
Member
|
Let's not add a dependency here. Let's find a solution without it. |
Contributor
Author
|
Hi ! Thanks for your answer ! I think both termios and atexit are part of python's std library, so it should not add any dependency. But as termios is POSIX only, it requires the try except for the import. So my patch will not affect at all non-POSIX systems but AFAIK those are not concerned with the issue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
=========================================
Coverage 87.683% 87.683%
=========================================
Files 104 104
Lines 7778 7778
Branches 1236 1236
=========================================
Hits 6820 6820
Misses 662 662
Partials 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahopkins
approved these changes
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2900 by simply saving term info and registering an on-exit handler to put correct term info back at the exit