Add some typing and fix some tests#3094
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the codebase, focusing on type safety, error handling, and test modernization. The most significant changes include stricter type annotations in cookie and worker modules, enhanced error handling for application loading, and updating HTTP/3 receiver tests to use asynchronous functions.
Type Safety and Error Handling Improvements:
sanic/cookies/response.pyto use explicit type annotations, improving type safety forexpires,max_age, andsamesite.samesitesetter insanic/cookies/response.pyto usecastfor type correctness when setting the value.sanic/worker/loader.pyto raise aValueErrorif the loaded app is not callable, providing clearer error messages during app loading.sanic/worker/serve.py, ensuring better compatibility and clarity with their expected types. [1] [2]Test Modernization:
tests/http3/test_http_receiver.pyto asynchronous functions (async def), aligning with modern async test practices and ensuring proper handling of async code in tests. [1] [2] [3] [4] [5] [6] [7] [8] [9]Other minor changes include importing
castfromtypingfor type casting in cookies and updating type hints foros.PathLikeusage.