Move to 2-stage coverage check#3108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a 2-stage coverage check workflow to work around limitations where the CODECOV_TOKEN is not accessible to PRs from non-contributors. The first stage runs coverage tests and uploads the coverage report as an artifact, while the second stage (triggered by workflow_run) downloads the artifact and uploads it to Codecov with proper authentication.
- Split coverage workflow into two stages: coverage generation and codecov upload
- First workflow runs on PR events and uploads coverage.xml as an artifact
- Second workflow uses workflow_run trigger to access secrets and upload to Codecov
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/coverage.yml |
Modified to upload coverage report as artifact instead of directly uploading to Codecov |
.github/workflows/coverage-upload.yml |
New workflow that downloads coverage artifact and uploads to Codecov with token access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully solve the problem where codecov was not running because the token is not available to PRs from non-contributors.