fix: prevent an unnecessary patch to set default languages on document #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaxarov
force-pushed
the
fix/az/unnecessary-patch-to-set-default-languages-on-document-deletion-event
branch
from
f6d938d to
1077b1e
Compare
SimeonGriggs
approved these changes
Sep 21, 2024
Contributor
SimeonGriggs
left a comment
SimeonGriggs
left a comment
There was a problem hiding this comment.
Tested locally, confirmed you can delete documents when the plugin config contains defaultLanguages.
SimeonGriggs
deleted the
fix/az/unnecessary-patch-to-set-default-languages-on-document-deletion-event
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the behaviour of
_createdAtfield has changed, meaning that the value is alwaysundefineduntil a document is published. Essentially, this new behaviour breaks the existing logic to set default languages when creating a new document.This has been earlier fixed here and further discussed here.