Update youtube_player_builder.dart #1025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix navigation pop error by canceling PopScope action if pop is alredy confirmed * - Refactor PopScope to pop if the player is not in fullscreen instead of always false. - Remove `Navigator.pop` inside `onPopInvokedWithResult` to avoid issues with external navigation (Example: Pressing dialog barrier, or using an external navigation solution) * 🎨 formaating fixes * fix: Full Screen in Landscape mode cut the video sarbagyastha#621 (sarbagyastha#962) * Full Screen in Landscape mode cut the video sarbagyastha#621 * Full Screen in Landscape mode cut the video sarbagyastha#621 * 🎨 minor changes * 🔖 bumped version * minor change * Version 9.1.0 (sarbagyastha#1001) * 👽 bumped version * ⬆️ upgraded flutter_inappwebview * 👽 macos changes --------- Co-authored-by: RaphiTobi <[email protected]> Co-authored-by: abulmajd <[email protected]> Co-authored-by: Nhật Long <[email protected]>
# Conflicts: # packages/youtube_player_flutter/CHANGELOG.md # packages/youtube_player_flutter/pubspec.yaml
change the onPopInvockedWthResult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the onPopInvockedWthResult