Repository navigation
fix(ci): skip the weekly rules sync when only the timestamp changed - #185
Merged
adityachaudhary-sarvam merged 1 commit intoOct 6, 2026
Conversation
…change The weekly sync always wrote sarvam_api_rules.json, including a new synced_at, so create-pull-request opened a pull request with no rule changes. Skip the write when the content fingerprint is unchanged.
Contributor
Author
|
The Monday rules sync was opening a pull request when only |
Collaborator
|
Hey @mangeshraut712, thanks for the contribution here, really appreciate it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129.
sync_sarvam_rules.pyalready computes a content fingerprint that ignoressynced_at, butmain()still wrotescripts/sarvam_api_rules.jsonon every run. The new timestamp was the only diff, so the Monday workflow opened a pull request that did not change any model or language list.The script now leaves the file untouched when that fingerprint matches. A real model-list change is still written.
Security checklist (required)
SARVAM_API_KEYis loaded from the environment — not hardcoded.envis gitignored (new recipes must include.env.example)New notebook recipe? (if applicable)
Not a recipe change.
Test plan
pytest tests/— all passedsynced_atis not rewrittenSARVAM_API_KEY— not applicable; this change does not call the APIRelated issues
Fixes #129