This repository was archived by the owner on May 15, 2023. It is now read-only.
Replace waitFor with async/await #136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces waitFor with async/await.
There's some trade off in terms of performance, see benchmark below. Personally I think this trade off is worth it as in most of the cases the performance is getting better.Update: Added a commit to fix regression. Performance is now either nearly equal or way better in every case. The code logic isn't really changed from the first attempt, but dart's compiler seems to have trouble optimize the old one correctly due to how type inference works.Update 2: still regress a lot in another case, see comment below.
Baseline 1.57.1 waitFor:
This PR 1.57.1 async/await:
Both tests are compiled locally with same dart version:
Benchmark code: