feat(loaders): Include CSS and image loaders in the webpack config #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@lsanwick Hey, thanks a lot! I would like to add css and assets support to quik itself too. Just haven't got enough time for that yet. If you could a send a PR for that as well, it'll be awesome. Also regarding this PR, can you add a line to the API doc also? Thanks :) |
Contributor
Author
|
If you want to make it support them by default, I'd be happy to change to that. I'm sure most people would like to have at least basic CSS and image support when prototyping. :) |
Right now, if I need to use assets like images, CSS, or fonts, Webpack won't load them and include them in the bundle. To make it possible to continue using Quik alongside these things, add the ability for the user to specify additional loaders to be included in the Webpack config.
lsanwick
force-pushed
the
ls/configurable-loaders
branch
from
5886162 to
71db8ee
Compare
lsanwick
changed the title
satya164
changed the title
Owner
|
Sorry, this was delayed. Thanks a lot for the PR :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if I need to use assets like images, CSS, or fonts, Webpack won't load them and include them in the bundle. To make it possible to continue using Quik alongside these things, add the ability for the user to specify additional loaders to be included in the Webpack config.