Skip to content

fix data mutation issue #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-bromann merged 2 commits into from
Aug 15, 2019
Merged

fix data mutation issue #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b73868
fix data mutation issue
farhan-sauce Aug 14, 2019
2b565f3
update unit tests
farhan-sauce Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,12 @@ export default class Tracelib {
throw new Error('MainTrack is missing in traceLog')
}

// We are facing data mutaion issue in devtools, to avoid it cloning syncEvents
const syncEvents = mainTrack.syncEvents().slice()

return {
...timelineUtils.statsForTimeRange(
mainTrack.syncEvents(), startTime, endTime
syncEvents, startTime, endTime
),
startTime,
endTime,
Expand Down