Skip to content

Minor refactoring #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-bromann merged 2 commits into from
Aug 16, 2019
Merged

Minor refactoring #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce50587
minor refactoring
christian-bromann Aug 16, 2019
5e0bb56
return mainTrack
christian-bromann Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,22 @@ export default class Tracelib {
}

private _findMainTrack(): Track {
return this._performanceModel
const mainTrack = this._performanceModel
.timelineModel()
.tracks()
.find((track: Track): boolean => Boolean(
track.type === TrackType.MainThread && track.forMainFrame && track.events.length
))
}

public getMainTrackEvents(): Event[] {
const mainTrack = this._findMainTrack()
if (!mainTrack) {
throw new Error('MainTrack is missing in traceLog')
}

return mainTrack
}
Comment thread
christian-bromann marked this conversation as resolved.

public getMainTrackEvents(): Event[] {
const mainTrack = this._findMainTrack()
return mainTrack.events
}

Expand All @@ -47,9 +50,6 @@ export default class Tracelib {
const startTime = from || this._performanceModel.startTime
const endTime = to || this._performanceModel.endTime
const mainTrack = this._findMainTrack()
if (!mainTrack) {
throw new Error('MainTrack is missing in traceLog')
}

// We are facing data mutaion issue in devtools, to avoid it cloning syncEvents
const syncEvents = mainTrack.syncEvents().slice()
Expand All @@ -65,9 +65,6 @@ export default class Tracelib {

public getWarningCounts(): StatsObject {
const mainTrack = this._findMainTrack()
if (!mainTrack) {
throw new Error('MainTrack is missing in traceLog')
}
return mainTrack.events.reduce((counter: StatsObject, event: Event): StatsObject => {
const timelineData = TimelineData.forEvent(event)
const warning = timelineData.warning
Expand Down