Skip to content

Assume CrRenderer thread to be the one with the most events#14

Merged
christian-bromann merged 2 commits into
masterfrom
cb-assume-crrenderer
Aug 21, 2019
Merged

Assume CrRenderer thread to be the one with the most events#14
christian-bromann merged 2 commits into
masterfrom
cb-assume-crrenderer

Conversation

@christian-bromann
Copy link
Copy Markdown
Contributor

@christian-bromann christian-bromann commented Aug 21, 2019

Problem

While testing this library we found that Chrome sometimes misses to capture all meta correctly. In ~10% of trace logs captured from Alexas 500 top used pages there following trace event is missing:

{"pid":99225,"tid":775,"ts":0,"ph":"M","cat":"__metadata","name":"thread_name","args":{"name":"CrRendererMain"}}

Which causes an error when trying to calculate a bunch of metrics.

Solution

As a workaround let's assume that the main thread is the one with the most events connected to it.

Copy link
Copy Markdown
Contributor

@farhan-sauce farhan-sauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann christian-bromann merged commit 750d047 into master Aug 21, 2019
@christian-bromann christian-bromann deleted the cb-assume-crrenderer branch August 21, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants