feat(sbb-form-field): add <sbb-hint> and <sbb-form-field-text-counter> components#4579
feat(sbb-form-field): add <sbb-hint> and <sbb-form-field-text-counter> components#4579jeripeierSBB wants to merge 21 commits intomainfrom
<sbb-hint> and <sbb-form-field-text-counter> components#4579Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the form field functionality by adding a new component to provide real-time feedback on character limits. It improves the user experience for input and textarea fields by clearly indicating how many characters are left, supporting multiple languages, and integrating smoothly with existing form field behaviors and styling. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. A haiku for the code: Max length set with care, Characters counted, clear view, Words flow, limits known. Footnotes
|
# Conflicts: # src/elements/form-field.ts # src/elements/form-field/form-field/form-field.stories.ts # src/elements/timetable-form/timetable-form-field/readme.md
github-actions
bot
added
pr: peer review required
| super.disconnectedCallback(); | ||
| this._formFieldAttributeObserver?.disconnect(); | ||
| this._inputFormAbortController.abort(); | ||
| if (this._input?.localName === 'input') { |
There was a problem hiding this comment.
| if (this._input?.localName === 'input' || this._input?.localName === 'textarea') { |
| return 'unchanged'; | ||
| } else if (this._input) { | ||
| this.internals.states.delete(`input-type-${this._input.localName}`); | ||
| if (this._input.localName === 'input') { |
There was a problem hiding this comment.
| if (this._input.localName === 'input' || this._input.localName === 'textarea') { |
jeripeierSBB
added
the
pr: a11y review required
TomMenga
left a comment
TomMenga
left a comment
There was a problem hiding this comment.
LGTM 👍
some minor improvements
| if (this.formField) { | ||
| this.negative = this.formField.hasAttribute('negative'); | ||
| } |
There was a problem hiding this comment.
| if (this.formField) { | |
| this.negative = this.formField.hasAttribute('negative'); | |
| } | |
| this.negative = this.formField?.hasAttribute('negative') ?? false; | |
| color: var(--sbb-form-field-label-color); | ||
| font-size: var(--sbb-text-font-size-xxs); |
There was a problem hiding this comment.
| color: var(--sbb-form-field-label-color); | |
| font-size: var(--sbb-text-font-size-xxs); | |
| /** Could be moved to global */ | |
| --sbb-form-field-hint-color: var(--sbb-form-field-label-color); | |
| --sbb-form-field-hint-font-size: var(--sbb-text-font-size-xxs); | |
| color: var(--sbb-form-field-hint-color); | |
| font-size: var(--sbb-form-field-hint-font-size); |
In theory, to fully support theme customization, it should have its own vars that could also be moved to global. You could argue that it's not worth it, though
2 participants
Closes #4512