refactor(navigation): css refactoring#4622
refactor(navigation): css refactoring#4622DavideMininni-Fincons wants to merge 5 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refactoring the CSS for the navigation components. It introduces global styles and improves theme support, ensuring consistency and maintainability across different themes and screen sizes. The changes include the addition of new global style files and modifications to existing SCSS files to incorporate these styles. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. In CSS, a style's embrace, Navigation finds its place. Refactored with care, Themes now debonair, A cleaner, smoother space. Footnotes
|
src/elements/navigation/navigation-marker/navigation-marker.global.scss
Outdated
Show resolved
Hide resolved
src/elements/navigation/navigation-section/navigation-section.global.scss
Outdated
Show resolved
Hide resolved
# Conflicts: # src/elements/core/styles/core.scss
# Conflicts: # src/elements/core/styles/core.scss
|
Note for reviewer: Not sure if a bug or as intended, but the size default values in navigation-marker match the button defaults (L/S), while the navigation-list has M/S |
jeripeierSBB
left a comment
There was a problem hiding this comment.
One last thing, but looks good, thank you!
Subtask of #3969