Skip to content

refactor(navigation): css refactoring#4622

Open
DavideMininni-Fincons wants to merge 5 commits intomainfrom
refactor/navigation
Open

refactor(navigation): css refactoring#4622
DavideMininni-Fincons wants to merge 5 commits intomainfrom
refactor/navigation

Conversation

@DavideMininni-Fincons
Copy link
Contributor

Subtask of #3969

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the CSS for the navigation components. It introduces global styles and improves theme support, ensuring consistency and maintainability across different themes and screen sizes. The changes include the addition of new global style files and modifications to existing SCSS files to incorporate these styles.

Highlights

  • CSS Refactoring: This PR refactors the CSS for the navigation components, improving maintainability and consistency.
  • Global Styles: Introduces global styles for navigation elements, including navigation, navigation action, navigation list, navigation marker, and navigation section.
  • Theme Support: Enhances theme support for navigation components, ensuring they adapt correctly to different themes (standard and lean).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/elements/core/styles/core.scss
    • Imported global styles for navigation components.
    • Included base styles for navigation elements.
    • Added breakpoint-specific styles for navigation components.
  • src/elements/navigation/common/navigation-action.global.scss
    • Created global styles for navigation actions, defining CSS variables for color, icon display, font size, letter spacing, and line height.
  • src/elements/navigation/common/navigation-action.scss
    • Updated navigation action styles to use CSS variables for positioning and transitions.
    • Added styles for different sizes (l, m, s) of navigation actions.
    • Refactored styles for navigation buttons and links.
  • src/elements/navigation/navigation-list/navigation-list.global.scss
    • Created global styles for navigation lists, defining CSS variables for gap, margin, and padding.
  • src/elements/navigation/navigation-list/navigation-list.scss
    • Updated navigation list styles to use CSS variables for spacing and label styling.
  • src/elements/navigation/navigation-marker/navigation-marker.global.scss
    • Created global styles for navigation markers, defining CSS variables for spacing, border, padding, font size, letter spacing, and line height.
  • src/elements/navigation/navigation-marker/navigation-marker.scss
    • Updated navigation marker styles to use CSS variables for spacing and font styling.
    • Added styles for different sizes (l, s) of navigation markers.
  • src/elements/navigation/navigation-section/navigation-section.global.scss
    • Created global styles for navigation sections, defining CSS variables for layout, positioning, padding, and font size.
    • Added breakpoint-specific styles for large and ultra screen sizes.
  • src/elements/navigation/navigation-section/navigation-section.scss
    • Updated navigation section styles to use CSS variables for layout and animation.
    • Removed redundant style definitions.
    • Adjusted title styling.
  • src/elements/navigation/navigation/navigation.global.scss
    • Created global styles for navigation, defining CSS variables for layout, padding, backdrop, background color, and font color.
    • Added breakpoint-specific styles for large and ultra screen sizes.
  • src/elements/navigation/navigation/navigation.scss
    • Updated navigation styles to use CSS variables for layout and animation.
    • Removed redundant style definitions.
    • Adjusted backdrop and content styling.
Activity
  • CSS refactoring for navigation components.
  • Addition of global styles for navigation elements.
  • Enhancement of theme support for navigation components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


In CSS, a style's embrace, Navigation finds its place. Refactored with care, Themes now debonair, A cleaner, smoother space.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 12, 2026
@github-actions github-actions bot temporarily deployed to pr4622 March 12, 2026 16:03 Inactive
@github-actions github-actions bot temporarily deployed to pr4622-diff March 12, 2026 16:05 Inactive
@github-actions github-actions bot temporarily deployed to pr4622-diff March 13, 2026 10:16 Inactive
@github-actions github-actions bot temporarily deployed to pr4622 March 13, 2026 10:18 Inactive
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Mar 13, 2026
82 tasks
# Conflicts:
#	src/elements/core/styles/core.scss
@github-actions github-actions bot temporarily deployed to pr4622 March 16, 2026 11:02 Inactive
@github-actions github-actions bot temporarily deployed to pr4622-diff March 16, 2026 11:09 Inactive
@DavideMininni-Fincons
Copy link
Contributor Author

Note for reviewer:
like the alert and the file-selector, also here there is has a internal setter for the navigation-action size.

Not sure if a bug or as intended, but the size default values in navigation-marker match the button defaults (L/S), while the navigation-list has M/S

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, but looks good, thank you!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diff-available pr: blocked Pull request is blocked either for merging or reviewing pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available target: 4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants