Skip to content

refactor(sbb-overlay): css refactoring#4657

Open
DavideMininni-Fincons wants to merge 2 commits intomainfrom
refactor/overlay
Open

refactor(sbb-overlay): css refactoring#4657
DavideMininni-Fincons wants to merge 2 commits intomainfrom
refactor/overlay

Conversation

@DavideMininni-Fincons
Copy link
Contributor

Subtask of #3969

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant CSS refactoring for the sbb-overlay component. The primary goal is to improve the maintainability and reusability of overlay styles by extracting global CSS variables and a base mixin into a dedicated global stylesheet. The component's main stylesheet has been updated to consume these new global variables, particularly for controlling display states, resulting in a more modular and consistent styling architecture.

Highlights

  • New Global Overlay Stylesheet: A new file, src/elements/overlay/overlay.global.scss, was introduced to centralize global CSS variables and a base mixin specifically for the overlay component, promoting better organization and reusability.
  • Overlay Component Refactoring: The src/elements/overlay/overlay.scss component was refactored to utilize the newly defined global CSS variables for managing display properties and other styling, replacing direct CSS declarations with variable usage for enhanced flexibility and consistency.
  • Core Stylesheet Updates: The src/elements/core/styles/core.scss file was updated to import the new global overlay stylesheet and adjust the usage of overlay-related mixins, including renaming an existing mixin alias.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


Old styles, tangled mess, New variables bring order, Clean code starts to bloom.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@DavideMininni-Fincons DavideMininni-Fincons changed the title refactor(sbb-overlay): css refactoring [WIP] refactor(sbb-overlay): css refactoring Mar 18, 2026
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Mar 18, 2026
@DavideMininni-Fincons DavideMininni-Fincons mentioned this pull request Mar 18, 2026
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant