Skip to content

CrossVersion.full strips off -bin-suffix. #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

milessabin
Copy link
Contributor

See discussion here.

@dwijnand
Copy link
Member

For @eed3si9n to decide if this can be included in 0.13.13, in which case it should be re-targeted for the 0.13.13 branch.

And then according to that decision, this needs notes in either notes/0.13.13.markdown or a file in notes/0.13.14/.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would break the sbt 0.13 semantics, and it would hurt the existing libraries that's actually using -bin (Lightbend Reactive Platform).

@eed3si9n
Copy link
Member

LGTM pending Travis.

@milessabin
Copy link
Contributor Author

Are you OK with this going into 0.13.13? If so I'll rebase to that and add release notes.

@dwijnand dwijnand changed the base branch from 0.13 to 0.13.13 September 28, 2016 15:38
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milessabin I've changed the target to 0.13.13.

Please could you amend the commit adding a note in notes/0.13.13.markdown?

@milessabin
Copy link
Contributor Author

Will do :-)

@dwijnand
Copy link
Member

Thanks. I want to get this into 0.13.13-RC2, which I'll cut tomorrow.

@dwijnand
Copy link
Member

0.13.13-RC3*

@eed3si9n
Copy link
Member

Are you OK with this going into 0.13.13?

Yes.

@eed3si9n
Copy link
Member

dwijnand changed the base branch to sbt:0.13.13 from sbt:0.13 an hour ago

This Github feature is so cool.

@milessabin
Copy link
Contributor Author

Notes added.

@milessabin
Copy link
Contributor Author

There was one failing job in the last build ... any ideas?

@dwijnand
Copy link
Member

Networking issues - #2758. I'll restart jobs until everything passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants