-
Notifications
You must be signed in to change notification settings - Fork 951
CrossVersion.full strips off -bin-suffix. #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a2b23a
to
a001381
Compare
For @eed3si9n to decide if this can be included in 0.13.13, in which case it should be re-targeted for the 0.13.13 branch. And then according to that decision, this needs notes in either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would break the sbt 0.13 semantics, and it would hurt the existing libraries that's actually using -bin
(Lightbend Reactive Platform).
a001381
to
b6f7a6a
Compare
LGTM pending Travis. |
Are you OK with this going into 0.13.13? If so I'll rebase to that and add release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milessabin I've changed the target to 0.13.13.
Please could you amend the commit adding a note in notes/0.13.13.markdown?
Will do :-) |
Thanks. I want to get this into 0.13.13-RC2, which I'll cut tomorrow. |
0.13.13-RC3* |
Yes. |
This Github feature is so cool. |
b6f7a6a
to
f560144
Compare
Notes added. |
There was one failing job in the last build ... any ideas? |
Networking issues - #2758. I'll restart jobs until everything passes. |
CrossVersion.full strips off -bin-suffix. Ref sbt/sbt#2757
See discussion here.