Skip to content

Update solidity-parser/parser to 0.20.1 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Conversation

cgewecke
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (e2126e7) to head (554f40d).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          19       19           
  Lines        1066     1066           
=======================================
  Hits         1030     1030           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cgewecke cgewecke marked this pull request as draft April 11, 2025 22:49
@cgewecke
Copy link
Member Author

Zeppelin's failing with this change due to OZ 5577

Error in plugin solidity-coverage: Error: Could not instrument: access/extensions/AccessControlEnumerable.sol. (Please verify solc can compile this file without errors.) mismatched input 'at' expecting {'from', 'error', 'address', 'calldata', 'revert', 'callback', 'leave', 'payable', 'global', 'constructor', 'receive', Identifier} (38:34)

HardhatPluginError: Error: Could not instrument: access/extensions/AccessControlEnumerable.sol. (Please verify solc can compile this file without errors.) mismatched input 'at' expecting {'from', 'error', 'address', 'calldata', 'revert', 'callback', 'leave', 'payable', 'global', 'constructor', 'receive', Identifier} (38:34)
    at SimpleTaskDefinition.action (/home/circleci/project/openzeppelin-contracts/node_modules/solidity-coverage/plugins/hardhat.plugin.js:294:35)

@cgewecke cgewecke marked this pull request as ready for review April 18, 2025 19:24
@cgewecke cgewecke changed the title Update solidity-parser/parser to 0.20.0 Update solidity-parser/parser to 0.20.1 Apr 18, 2025
@cgewecke cgewecke merged commit c06fe7c into master Apr 18, 2025
3 checks passed
@cgewecke cgewecke deleted the update-parser-0.20.0 branch April 18, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants