remove restriction for useScaffoldContractRead generic #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverps
requested changes
Mar 7, 2023
sverps
approved these changes
Mar 8, 2023
rin-st
approved these changes
Mar 8, 2023
Member
|
This makes sense. Thanks for the discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed it while hacking se-2 :
You are not able to pass other types as generic expect
BigNumber | boolean | string, I think we should not restrict just toBigNumber | boolean | stringand allow developers to pass in what they want, since sometime your function may returnstructor other types.Added
polygonMumbaito.env's, lots of people usemumbaifor hacking and it would great if we add reference in comments itself so that developers don't have to go to wagmi's doc (we can completely ignore this though)