-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use .config for frontend instead of env's #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @technophile-04 great job! Left a few comments. I think this should be the way to go, right? At least initially. (instead of #231 ) |
Yes for now 🙌, also added a small comment #231 (comment) there for the need of this PR |
It doesn't really bother me. It's a little more verbose, but at the same time it makes it obvious where the value is coming from (scaffold config), rather than abstracting this knowledge away. Maybe we can improve it a bit by making the scaffold config a named export, and naming the const simply |
Great job everyone! Merged this. Let's see how it feels, and don't forget about #231 |
Description
Added a
scaffold.config.ts
in frontend instead for now as discussed in #231.Updated
network.ts
now it uses block explores links fromtargetNetowork
and now you get transaction link for different blockexplores previously it used only show for etherscan and dai.... its the same as #231 (comment)would love to make it more robust and inline in different PR 🙌
Flow :
targetNetwork
fromscaffold.config.ts
is single source of truth now for frontendscaffold.config.ts