Ethers v6 migration in hardhat #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tysm all !! I think after #692 we could merge this 🙌 |
Member
|
Works great!
recursion 😄 |
rin-st
approved these changes
Jan 16, 2024
Member
lol Great job @technophile-04. Add uncommented example code as we talked on TG. Let's also add this to the weekly CLI merge. |
Collaborator
Author
😂 lol my bad wanted to add that comment at #685 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we updated all the hardhat related packages in #637, but it seems that if you uncomment :
scaffold-eth-2/packages/hardhat/deploy/00_deploy_your_contract.ts
Line 35 in e4c7007
You get an error, which I think is caused due to
hardhat-deploy-ethersandhardhat-ethersdigging few discussion it seems that updating ethers to v6 does seems to solve this issue due to some internal api changes