remove extra notifications when using useTransactor #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technophile-04
requested review from
Pabl0cks,
carletex,
damianmarti and
rin-st
Pabl0cks
reviewed
Mar 10, 2024
Collaborator
Pabl0cks
left a comment
Pabl0cks
left a comment
There was a problem hiding this comment.
Nice catch, gj Shiv! Looks good to me 🙌
Pabl0cks
approved these changes
Mar 10, 2024
Collaborator
Author
|
Tysm guys ! Merging this 🙌 |
Merged
Merged
technophile-04
added a commit
to BuidlGuidl/abi.ninja
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed this while testing #756, it was caused in #758 :
Screen.Recording.2024-03-10.at.10.03.32.AM.mov
When you get an error while sending transaction, it shows notification two times, this is due to since in #758, we are not eating up error in
useTransactorinstead showing notification + throwing it forward.In 2746877 removed our own showing of notification or error again since its same already shown in
useTransactorFor more details checkout : #758 (review)