Skip to content

Conversation

@JacobHomanics
Copy link
Contributor

Description

Goerli has been effectively deprecated and is no longer supported by major RPC clients, thus we can safely remove it from the template as it appears as unnecessary fluff.

Additional Information

Your ENS/address: JacobHomanics.eth

@carletex
Copy link
Member

Thanks @Hotmanics!

Always feels good to remove stuff :D

Could you remove other appearances of goerli in the codebase?

  • Deploy script (see the commented section). Maybe switch for sepolia.
  • networks.ts on the next app

@JacobHomanics
Copy link
Contributor Author

Thanks @Hotmanics!

Always feels good to remove stuff :D

Could you remove other appearances of goerli in the codebase?

  • Deploy script (see the commented section). Maybe switch for sepolia.
  • networks.ts on the next app

ah great! Did not realize it was in those places. Thanks!

This PR now accounts for those files!

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hotmanics , and also others for reviews and test looking good !

@technophile-04 technophile-04 merged commit 9b9fbaa into scaffold-eth:main Mar 12, 2024
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants