Remove nprogress + use next-nprogress-bar #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
approved these changes
Sep 18, 2024
Member
rin-st
left a comment
rin-st
left a comment
There was a problem hiding this comment.
Agree let's return to next-progress-bar since it's up to date. Working great for me!
technophile-04
approved these changes
Sep 19, 2024
Collaborator
technophile-04
left a comment
technophile-04
left a comment
There was a problem hiding this comment.
Makes sense! Also seems to nicely work with a tags(not showing the loader)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we migrated to the App Router #535 we switched from https://www.npmjs.com/package/next-nprogress-bar to https://www.npmjs.com/package/nprogress + creating a custom integration with the App Router.
We already had an issue with external
_blanklinks #909 and now I realized that we have the same problem with hash links (#section). The progress bar will start to load (it shouldn't do anything)One solution will be to just parse the #links and fix it, but created this PR with another alternative: moving back to
next-nprogress-barwhich has been updated and supports the App Router nicely. Under the hood it does the same thing that we are doing, but it's handling some stuff a bit better. So it'll be moving custom logic to an external library.Happy to close this, just wanted to hear your take on it.
Thanks!!