Add yarn account:reveal-pk command explanations
#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carletex
reviewed
May 20, 2025
|
|
||
| You will get prompted to paste your private key and set the encryption password. It will store your encrypted private key in your `.env` file. | ||
|
|
||
| To reveal the private key of your currently configured deployer account (from `.env`), you can run: |
Member
There was a problem hiding this comment.
For me, it'd make sense to have reveal-pk as the last command
- generate
- account:import
- account
- reveal-pk
Not a big deal tho! But maybe we could move the account instructions inside each hardhat / foundry tab so we can put it before reveal-pk? (even if we are duplicating it)
Collaborator
Author
There was a problem hiding this comment.
Agree! It was actually my initial approach. but then I changed it. Makes sense to follow this workflow 🙏
I've added bold to the 4 actions to make sure they stand out (using subtitles felt a bit too much but could be also an option!)
technophile-04
approved these changes
May 21, 2025
Collaborator
technophile-04
left a comment
technophile-04
left a comment
There was a problem hiding this comment.
Tysm @Pabl0cks!! Just added a small comment feel free to ignore 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for
yarn account:reveal-pkcommand for Hardhat and Foundry.Got added to SE-2 in scaffold-eth/scaffold-eth-2#1094 and scaffold-eth/scaffold-eth-2#1091