Adapt docs to App Router update and add Foundry use case to verify section #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Tysm @Pabl0cks !! Just added a small comment but other than that everything looks good !! |
edakturk14
reviewed
Jan 18, 2024
Collaborator
edakturk14
left a comment
edakturk14
left a comment
There was a problem hiding this comment.
Thank you @Pabl0cks!! made a few nitpicks for readability, hope you like them. Open to any suggestions and feel free to disregard or leave any comments aswell!
Collaborator
Author
|
Thanks for the review a suggestions @technophile-04 and @edakturk14 !! I've just pushed the changes 🙌 |
technophile-04
approved these changes
Jan 21, 2024
Collaborator
technophile-04
left a comment
technophile-04
left a comment
There was a problem hiding this comment.
Tysm all !! Merging this 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these two changes in the same PR, they are not related but are small enough to not create 2 PRs I think:
yarn deploy:verifybut maybe just adds complexity to the section. What do you think?Regarding Documenting folder structure I think we could document the components structure in
/componentscategory description. Another possibility would be adding a new bullet point in "What's Next" from/quick-start/environment, with something like "Add new components (if you need any) in...".Let me know what do you think, thanks! 🙌