The XML Utility.escape method does not treat control characters properly

[scabug]

Control characters (other than \r, \n and \t) are illegal in XML. The Utility.escape method does not filter these characters, leading to illegal XML.

The enclosed patch filters control characters from XML output and improves performance over the 2.7.7 implementation by 3x and the 2.8 implementation by 4x (as benchmarked by the attached file)

[scabug]

Imported From: https://issues.scala-lang.org/browse/SI-3014?orig=1
Reporter: David Pollak (dpp)
Attachments:

• scala_xml_fix.diff (created on Feb 3, 2010 4:22:47 AM UTC, 1077 bytes)
• XmlThing.scala (created on Feb 3, 2010 4:21:51 AM UTC, 1290 bytes)

[scabug]

David Pollak (dpp) said:
Benchmark existing implementation vs. new implementation

[scabug]

David Pollak (dpp) said:
Patch to the 2.8 codebase

[scabug]

David Pollak (dpp) said:
(In r20780) Fixed XML Utility.escape method to conform to XML spec. Closes #3014