Shapeless build fails in recent 2.11.x builds #202
Comments
|
looks like milessabin/shapeless@aede308 is the culprit |
|
note that scalamacros/paradise used to be part of the community build, but was removed in ecae16d |
|
test run w/ paradise added: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/190/console |
|
adding paradise wasn't enough, needed to add milessabin/macro-compat as well. this led to (in this run): for reasons I don't understand. the logic in https://github.com/milessabin/macro-compat/blob/master/build.sbt for only including the quasiquotes dependency on 2.10 seems correct to me: > eval CrossVersion.partialVersion("2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d")
[info] ans: Option[(Int, Int)] = Some((2,11))
> ++2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d show libraryDependencies
[info] Setting version to 2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d
[info] Reapplying settings...
[info] Set current project to test (in build file:/Users/tisue/macro-compat/)
[info] List(org.scala-lang:scala-library:2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d, org.scala-lang:scala-reflect:2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d:provided, org.scala-lang:scala-compiler:2.11.8-dbuildx1df2747ab4cf758a246c29f4688c6bdee4ad043d:provided, org.scalamacros:paradise:2.1.0:plugin->default(compile), org.scalatest:scalatest:3.0.0-M12:test, org.scalacheck:scalacheck:1.12.5:test)no quasiquotes! so why does it end up as a dependency in the context of the community build? |
|
fyi @milessabin |
|
to get the build green again, in #204 I froze Shapeless at d6a4f56e0783655c48244ec23c4f4c2d98401a72 for now |
|
@gkossakowski any insight? |
|
The change in milessabin/shapeless@aede308 is a switch from a multi-branch build (ie. separate branches for 2.10.x and 2.11.x+) to a single branch build using macro-compat. macro-compat is needed as a dependency for 2.11.x+ but that should be incredibly lightweight ... just enough to completely eliminate an We're currently cross-building for 2.12.0-M3 without a problem ... I'm not clear what the issue is here? |
|
Is macro-compat itself part of the community build? |
|
It's a shame macro-compat isn't in the community builds as I guess it would also be broken, and would've broken long before this ticket. And it would've either been broken when trying to add it, or we would've been able to bisect to what broke it.. |
|
Probably not useful given dbuild uses the sbt builds instead of the artefacts, but there's no macro paradise in the poms: |
|
Any more info on this? |
|
I heard a rumour that you can't have builds in the community build without all its dependencies also in the community build. So perhaps the next step is to add macro-compat? |
it wasn't, but I tried adding it as part of my attempt to fix this. I already said so in #202 (comment), you might want to give that comment a closer re-read in order to understand where we stand with this. |
|
@SethTisue One suspect, to me at least, is the log line: It looks to me like it wants to test building everything against scala version Does that looks suspect to you? Do you know why it might be doing that? |
|
macro-compat has a .sbtrc which contains, Could that be the issue? It doesn't cause a problem on Travis. |
|
Good find, yeah it could very well be. For reference that's there for the development convenience of test compiling and running tests under 2.10.6. |
|
Oh and the convenience of test compiling and running tests only for the JVM, not Scala.js, during development. |
|
@SethTisue That's been merged now ... could you give it another try? |
|
That seems to have worked? |
because latest Shapeless needs them. fixes scala#202
|
merged #206. thanks, Dale and Miles! nice not just to get the regression fixed, but to get two new projects in. |
|
Cool :) |
because latest Shapeless needs them. fixes scala#202
The text was updated successfully, but these errors were encountered: