Skip to content

Use "nodejs" in all Scala.js projects that testSuite depends on. #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SethTisue merged 1 commit into from
Sep 19, 2016
Merged

Use "nodejs" in all Scala.js projects that testSuite depends on. #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions common.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,10 @@ build += {
// - Disable fatal Scaladoc warnings, also fragile
"removeScalacOptions -Xfatal-warnings",
// - Use Node.js with the executable "nodejs" instead of "node" (environmental in the CI infrastructure)
// We disable source map tests to save ourselves a `npm install source-map-support` on the workers
"set jsEnv in testSuite := NodeJSEnv(executable = \"nodejs\").value.withSourceMap(false)"
// We disable source map tests to save ourselves a `npm install source-map-support` on the workers.
// Although only `testSuite` actually has tests, dbuild will try to run the tests for all projects
// that `testSuite` depends on (transitively), so we need to set it in a bunch of places.
"set Seq(library, testInterface, jUnitRuntime, testSuite).map(p => jsEnv in p := NodeJSEnv(executable = \"nodejs\").value.withSourceMap(false))"
]
}
}
Expand Down