-
Notifications
You must be signed in to change notification settings - Fork 4
Add banner to frozen files #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to change the source files of the website, instead of the generated html files? It would be easier to change the banner, if needed.
I am not sure that showing the commit hash is much useful to the readers. Instead, I would just say that the content is not maintained anymore, and up to date documentation can be found at https://docs.scala-lang.org. The link you added to each page might be invalid if at some point we decide to rename things in the repository, so I would just delete that link.
I can push changes to the branch so the pregenerating banners would be simple
I know it's a little tricky, I wanted to add a link to dotty repo at given revision for "curious" users.
Given the fact that there is not yet continuous deployment set up, we cannot guarantee that up-to-date version can be found at Or if you don't like the preprocessing we can at least merge md files to the dotty repo and just create pain copy-paste action, but the advantage will be that they will be finally rendered at docs.scala-lang |
Yes, but please push them on a separate PR than 13350. I insist that we can’t merge 13350 before we have a frozen website (which means, not overwritten by nightly CI) showing a large banner pointing readers to docs.scala-lang.org.
OK, maybe you can keep it at the end?
docs.scala-lang.org is already the most up-to-date documentation. What we are trying to do now is to move some content sources back to the dotty repo so that compiler maintainers can update them as they update the compiler. Most of the changes in the dotty repo are about experimental features, which are … experimental and not widely used, so I think it is acceptable if there is a delay of a few weeks before we update them on docs.scala-lang.org via the continuous deployment set up you are thinking about. |
Yes, that's what I meant.
If you say so... I just felt that telling directly that they are up-to-date is a falsehood, since they differ (even though these are small changes, like experimental API etc.) |
Here is the PR that freezes the site scala/scala3#13550 What do you think? |
Closing since we probably won't merge it |
No description provided.