-
Notifications
You must be signed in to change notification settings - Fork 17
Introduce new scalaVersionsByJvm setting #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @gourlaysama, suggestions welcome. |
cc our other module maintainers: @benhutchison @danslapman @ashawley @biswanaths (it would be good if y'all watched this repo if you aren't already — it's low-noise) |
Looks nice, I like the concept! |
I've tested this with scala-continuations and scala-swing, seems to work fine. I'll merge and publish a new release of this plugin. |
Will this change be compatible with the scalajs plugin? |
That's also a good question! I'll look at the scala-xml repo and see what needs to be done to make sure it works fine in scala-xml. |
Another problem is in the https://github.com/scala/scala-parallel-collections build which only sets
Maybe instead of making it a setting, I better define a method that the module builds can invoke when setting |
So far I have scalaVersionsByJvm := {
val v213 = "2.13.0-M1"
val v212 = "2.12.2"
val v211 = "2.11.11"
val vs = List(v213, v212, v211)
// Map[JvmMajorVersion, List[(ScalaVersion, UseForPublishing)]]
Map(
6 -> List(v211 -> true),
7 -> List(v211 -> false),
8 -> List(v213 -> true, v212 -> true, v211 -> false),
9 -> vs.map(_ -> false)
)
} But I get
|
- Update scala-module-plugin to 1.0.6 - Use scalaVersionsByJvm to set crossScalaVersions and scalaVersion - Based on scala/scala-swing#60 - Motivated by scala/sbt-scala-module#18
- Update scala-module-plugin to 1.0.6 - Use scalaVersionsByJvm to set crossScalaVersions and scalaVersion - Based on scala/scala-swing#60 - Motivated by scala/sbt-scala-module#18
- Update scala-module-plugin to 1.0.6 - Use scalaVersionsByJvm to set crossScalaVersions and scalaVersion - Based on scala/scala-swing#60 - Motivated by scala/sbt-scala-module#18
I don't see anything in here that would interfere with sbt-scalajs. I could be overlooking something, of course. |
Make it easier for modules to use multiple Scala versions depending on the JVM version. Example config in a module:
This will set
crossScalaVersions
according to the JVM version. If theTRAVIS_TAG
environment variable is defined and we're publishing a release, the selection of Scala versions is filtered accordingly.