Provide keys through autoImport #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippus
force-pushed
the
provide-keys-though-autoimport
branch
2 times, most recently
from
9466d35 to
31f5288
Compare
|
review by @eed3si9n ? |
eed3si9n
requested changes
Apr 16, 2019
| val mimaPreviousVersion = settingKey[Option[String]]("The version of this module to compare against when running MiMa.") | ||
| val scalaVersionsByJvm = settingKey[Map[Int, List[(String, Boolean)]]]("For a Java major version (6, 8, 9), a list of a Scala version and a flag indicating whether to use this combination for publishing.") | ||
| object autoImport { | ||
| val repoName = settingKey[String]("The name of the repository under github.com/scala/.") |
There was a problem hiding this comment.
sbt Plugins Best Practice recommends that we use plugin-specific prefix for all keys to avoid conflict - https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Key+naming+convention%3A+Use+prefix
If we are making these keys available automatically via autoImport, we should use our own prefix.
| val scalaVersionsByJvm = settingKey[Map[Int, List[(String, Boolean)]]]("For a Java major version (6, 8, 9), a list of a Scala version and a flag indicating whether to use this combination for publishing.") | ||
| object autoImport { | ||
| val repoName = settingKey[String]("The name of the repository under github.com/scala/.") | ||
| val mimaPreviousVersion = settingKey[Option[String]]("The version of this module to compare against when running MiMa.") |
There was a problem hiding this comment.
mima is a prefix used by MiMa plugin, so this especially seems bad, as it would cause a conflict if MiMa decides to add this feature.
eed3si9n
approved these changes
Jul 8, 2019
|
Could you rebase this plz? |
Philippus
force-pushed
the
provide-keys-though-autoimport
branch
from
5bc44e0 to
33831d1
Compare
Philippus
force-pushed
the
provide-keys-though-autoimport
branch
from
33831d1 to
1a2140c
Compare
|
Thanks, @Philippus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30