Workaround for existential bind / resetAttrs interaction #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the continuations plugin from scalaHome, rather than from the downloaded dependencies - Add a task, `patch-idea`, to run after `gen-idea`. This task updates the IntelliJ classpath (and associated sources) to the local copy of Scala.
This helps readers, and IntelliJ, comprehend the code.
Hopefully we can do without this sooner rather than later, but until then, let's make it a little easier to debug.
The original trees for pattern matching Binds are somewhat unusual.
pat = (s#4999 @ (_: Seq#41[_#5000]))
`------- Typed ---'
`--------- Bind -------------'
val Typed(_, tpt: TypeTree) = <<(_: Seq#41[_#5000])>>
val AppliedTypeTree(<<scala.Seq#41>>, (arg: TypeTree) :: Nil) = tpt.original
val Bind(_#5000, EmptyTree) = arg.original
This commit manually resets the typed `_#5000` to `Ident(tpename.WILDCARD)`.
I'm not sure yet whether scalac ought to present a fully untyped original here.
|
About to be superseded by a better fix. |
retronym
added a commit
to retronym/async
that referenced
this pull request
Jul 2, 2013
- Avoid reset + retypecheck, instead hang onto the original types/symbols
- Eliminated duplication between AsyncDefinitionUseAnalyzer and ExprBuilder
- Instead, decide what do lift *after* running ExprBuilder
- Account for transitive references local classes/objects. Still a few issues
with the way we lift them, so the restrictions haven't been removed yet.
- Make the execution context an regular implicit parameter of the macro
- Fixes interaction with existential skolems and singleton types
Fixes scala#6, scala#13, scala#16, scala#17, scala#19, scala#21.
retronym
added a commit
to retronym/async
that referenced
this pull request
Jul 3, 2013
- Avoid reset + retypecheck, instead hang onto the original types/symbols
- Eliminated duplication between AsyncDefinitionUseAnalyzer and ExprBuilder
- Instead, decide what do lift *after* running ExprBuilder
- Account for transitive references local classes/objects and lift them
as needed.
- Make the execution context an regular implicit parameter of the macro
- Fixes interaction with existential skolems and singleton types
Fixes scala#6, scala#13, scala#16, scala#17, scala#19, scala#21.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original trees for pattern matching Binds are somewhat unusual.
This commit manually resets the typed
_#5000toIdent(tpename.WILDCARD).I'm not sure yet whether scalac ought to present a fully untyped original here.
Review by @phaller