Skip to content

drop support for Scala 2.11 as of 0.10.0 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2018

Conversation

SethTisue
Copy link
Member

also upgrade Scala 2.12.4 -> 2.12.6

also upgrade Scala 2.12.4 -> 2.12.6
@SethTisue SethTisue force-pushed the drop-scala-2.11-support branch from d6ab9f6 to f8a5b00 Compare May 1, 2018 11:05
@SethTisue
Copy link
Member Author

@retronym the motivation here is to pave the way to move to sbt 1 by dropping Java 7 support

@SethTisue SethTisue requested a review from retronym May 1, 2018 11:07
@SethTisue
Copy link
Member Author

SethTisue commented May 1, 2018

if this is merged, at the same time we'll need to the create a new 2.11.x branch, which README.md references

@SethTisue
Copy link
Member Author

SethTisue commented May 1, 2018

the broader issue of sbt 1 support for modules is being discussed at scala/sbt-scala-module#32

here in this repo, there's no great need to be on sbt 1. so Jason, I guess this basically depends on whether you consider dropping 2.11 support to be a nice simplification that would make your life in this repo a little easier, going forward.

@retronym retronym merged commit d8444ab into scala:master May 4, 2018
@retronym
Copy link
Member

retronym commented May 4, 2018

Thanks. Agree the time is right.

This will simplify #194, as no longer have to avoid using Java SAMs.

@retronym
Copy link
Member

retronym commented May 4, 2018

if this is merged, at the same time we'll need to the create a new 2.11.x branch, which README.md references

Done: https://github.com/scala/scala-async/tree/2.11.x

@SethTisue SethTisue deleted the drop-scala-2.11-support branch May 4, 2018 07:56
@SethTisue
Copy link
Member Author

2.11 community build updated: scala/community-build@20a94d9

@retronym retronym added this to the 0.10 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants