Skip to content

Add groupMap and groupMapReduce extensions #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

NthPortal
Copy link
Contributor

Fixes #11

@NthPortal NthPortal added the library Related to compat library code (not rewrite rules) label Jan 10, 2020
@NthPortal
Copy link
Contributor Author

I think there's some MiMa twiddling that needs to happen, but I believe this code should pretty much work

@NthPortal NthPortal mentioned this pull request Jan 12, 2020
@julienrf
Copy link
Contributor

Unfortunately, this PR is not backward compatible (see https://stackoverflow.com/a/18369508/561721 for an explanation of why).

I think we could create a 2.x branch where we could apply backward-compatible changes (if needed).

And branch master could be the place where we prepare the 3.x release…

What do others think?

@lrytz
Copy link
Member

lrytz commented Jan 13, 2020

Maybe the toTraversableLikeExtensionMethods method can be duplicated and added directly to the compat objects, instead of the PackageShared super trait? That would avoid the binary incompatibility on 2.11.

@NthPortal
Copy link
Contributor Author

NthPortal commented Jan 13, 2020

for future versions, can PackageShared be an abstract class rather than a trait (thus sidestepping the problem)? I don't know the rules about what a package object can and can't extend

@NthPortal
Copy link
Contributor Author

@lrytz yup, I'll do that

@julienrf
Copy link
Contributor

@NthPortal Yes, that should work (see #292)

@NthPortal NthPortal changed the title #11 Add groupMap and groupMapReduce extensions Add groupMap and groupMapReduce extensions Jan 13, 2020
@NthPortal
Copy link
Contributor Author

cleaned up, squashed, and ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Related to compat library code (not rewrite rules)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add groupMap and groupMapReduce
3 participants